Enumerable#split, any advice on this implementation ?

[Thibaut Barrère]

Hi

could more advanced rubyists review this code (it's already a mixture
of several things I've seen, but a review cannot hurt!) ?

module Enumerable
def split(pattern)
inject([]) do |memo,obj|
memo.push [] if obj =~ pattern
memo.last << obj
memo
end
end
end

Typical usage: split an array like ['Application starting...','I do
work','Application starting...','I still do work'] into [['Application
starting...','I do work'],['Application starting...','I still do
work']].

(or is there something built-in to handle that?)

thanks!

Thibaut

 

[Robert Klemme]

Hi

could more advanced rubyists review this code (it's already a mixture
of several things I've seen, but a review cannot hurt!) ?

module Enumerable
def split(pattern)
inject([]) do |memo,obj|
memo.push [] if obj =~ pattern
memo.last << obj
memo
end
end
end

Typical usage: split an array like ['Application starting...','I do
work','Application starting...','I still do work'] into [['Application
starting...','I do work'],['Application starting...','I still do
work']].

(or is there something built-in to handle that?)

Not that I know of. The name collides with String#split which behaves a
bit differently. And I'd use "pattern === obj" instead of "obj =~
pattern" because that is more generic. Then you can even use a class
object for splitting. Other than that it looks good IMHO.

Kind regards

robert

 

[Trans]

#partition (?)

 

[Robert Klemme]

#partition (?)

no.

 

[Trans]

no.

Ah right. I see. How about #divide_on, or something like that?

T.

 

[transfire]

Ah right. I see. How about #divide_on, or something like that?

Now I recall. It's more akin to to Facets' String#shatter.

T.