File Output Problem

[aidy]

Hi,

I am reading a txt file, e.g.

;Country Depot EmployeeID FirstName LastName UserID
null BERLIN G744ahe null Rutter 123

This is the code:

def enter_employees()
f = File.new('c:\employee_data.txt')
f.each do |line|
if !line.include? ";"
data = line.chomp.split(' ')
i = 0
while i < data.length do
if data != "null" or data != nil
puts "i = #{i}"
puts data
i += 1
end
end
end
end
end
enter_employees()

I am trying not to print to the console if data == "null", however
this is the output

i = 0
null
i = 1
BERLIN
i = 2
G744ah
i = 3
null
i = 4
Rutter
i = 5
123

Could someone tell me what I am doing wrong?

Thanks

Aidy

 

[ChrisH]

This line:
if data != "null" or data != nil
should be
if data != "null" and data != nil

In the first case when data=="null" than data != nill so the
statement is True, and likewise if data==nil than data != "null"
and the statement is again True

 

[lloyd]

you could also use:

unless data =="null" or data == nil
puts "i = #{i}"
puts data

some people make better sense using unless because the logic isnt
negated and reads more logically. personally i have no preference but
it may work for you

 

[aidy]

Not so sure whether you are supposed to say thanks on the list; but
thanks for the help and ideas.

Aidy

 

[ChrisH]

Here's how I'd write it:

def enter_employees()
File.open('employee_data.txt','r'){|f| #use block so file is
automatically closed
f.each_line { |line|
next if /^;/ =~ line #check for ';' at start of line
i = 0
line.chomp.split(' ').each{|x|
next if x.nil? or x == "null" #skip nil or "null" values
puts "i = #{i}", x
i += 1
}
}
}
end

Cheers
Chris

 

[Robert Klemme]

Hi,

I am reading a txt file, e.g.

;Country Depot EmployeeID FirstName LastName UserID
null BERLIN G744ahe null Rutter 123

This is the code:

def enter_employees()
f = File.new('c:\employee_data.txt')
f.each do |line|
if !line.include? ";"
data = line.chomp.split(' ')
i = 0
while i < data.length do
if data != "null" or data != nil
puts "i = #{i}"
puts data
i += 1
end
end
end
end
end
enter_employees()

I am trying not to print to the console if data == "null", however
this is the output

i = 0
null
i = 1
BERLIN
i = 2
G744ah
i = 3
null
i = 4
Rutter
i = 5
123

Could someone tell me what I am doing wrong?

Thanks

Aidy

Dunno whether this is what you want...

17:21:54 [Temp]: cat dat
;Country Depot EmployeeID FirstName LastName UserID
null BERLIN G744ahe null Rutter 123
17:22:00 [Temp]: ruby -naF\\s+ -e '/^;/ =~ $_ or puts $F.reject {|x|
"null"==x}' dat
BERLIN
G744ahe
Rutter
123

Kind regards

robert