Flat file missing

[asg]

i use the code below for a page counter. when it gets to around a 900
count, it resets to 1. any ideas as to why?



my $counterFile = "adcounter/page1";

if (-e $counterFile) {
open(COUNT,"$counterFile");
flock (COUNT, 2);
my $ergsege= <COUNT>;
close(COUNT);
$ergsege++;
open(COUNT,">$counterFile");
print (COUNT "$ergsege");
close(COUNT);
flock (COUNT, 8);
}
else{
my $ergsege= "1";
open(COUNT,">$counterFile");
flock (COUNT, 2);
print COUNT "1";
close(COUNT);
flock (COUNT, 8);
}

 

[J. Gleixner]

i use the code below for a page counter. when it gets to around a 900
count, it resets to 1. any ideas as to why?

page counter... A cold chill goes through the newsgroup...

Two quick reasons:
The file didn't exist.
The open failed, therefore ergsege is undefined/0.

There's no way to tell because you aren't checking if
the various functions were successful or not.

my $counterFile = "adcounter/page1";

if (-e $counterFile) {
open(COUNT,"$counterFile");
flock (COUNT, 2);
my $ergsege= <COUNT>;
close(COUNT);
$ergsege++;
open(COUNT,">$counterFile");
print (COUNT "$ergsege");

print COUNT $ergsege;

close(COUNT);
flock (COUNT, 8);
}
else{
my $ergsege= "1";
open(COUNT,">$counterFile");
flock (COUNT, 2);
print COUNT "1";
close(COUNT);
flock (COUNT, 8);
}

This is a pretty poor way to do what you want, for
a much better approach, see:

perldoc -q "I still don't get locking."

 

[Jürgen Exner]

i use the code below for a page counter.

See "perldoc -q increment"

jue

 

[Gunnar Hjalmarsson]

i use the code below for a page counter. when it gets to around a 900
count, it resets to 1. any ideas as to why?

Others have pointed you to better ways to do what you want. I for one am
a happy user of DBM files for page counters. See this script for an
example: http://www.gunnar.cc/programs/counter.pl.txt

 

[Tad McClellan]

open(COUNT,"$counterFile");

open(COUNT, $counterFile) or die "could not open '$counterFile' $!";

print (COUNT "$ergsege");

print (COUNT $ergsege);


See:

perldoc -q vars

What's wrong with always quoting "$vars"?