Fw: Undeliverable Message

[Matthew_WARREN]

Hallo pyPeople,

I wrote a little snippet of code that takes a list representing some
'digits', and according to a list of symbols, increments the digits through
the symbol list.

so for example,

digits=["a","a","a"]
symbols=["a","b","c"]


increment(digits,symbols) repeatedly would return digits as

aab
aac
aba
abb
abc
aca


etc..

Heres the code

def increment(digits,symbols):
overflow=True
digitpos=-1
while overflow and -digitpos<=len(digits):
digitsymbolindex=symbols.index(digits[digitpos])
if digitsymbolindex==len(symbols)-1:
overflow=True
digits[digitpos]=symbols[0]
digitpos=digitpos-1
else:
digits[digitpos]=symbols[digitsymbolindex+1]
overflow=False
return digits



Now, this works. All good. It's nice and simple. I'm just wondering how
anyone else might approach it?


Matt.


This message and any attachments (the "message") is
intended solely for the addressees and is confidential.
If you receive this message in error, please delete it and
immediately notify the sender. Any use not in accord with
its purpose, any dissemination or disclosure, either whole
or partial, is prohibited except formal approval. The internet
can not guarantee the integrity of this message.
BNP PARIBAS (and its subsidiaries) shall (will) not
therefore be liable for the message if modified.
Do not print this message unless it is necessary,
consider the environment.

---------------------------------------------

Ce message et toutes les pieces jointes (ci-apres le
"message") sont etablis a l'intention exclusive de ses
destinataires et sont confidentiels. Si vous recevez ce
message par erreur, merci de le detruire et d'en avertir
immediatement l'expediteur. Toute utilisation de ce
message non conforme a sa destination, toute diffusion
ou toute publication, totale ou partielle, est interdite, sauf
autorisation expresse. L'internet ne permettant pas
d'assurer l'integrite de ce message, BNP PARIBAS (et ses
filiales) decline(nt) toute responsabilite au titre de ce
message, dans l'hypothese ou il aurait ete modifie.
N'imprimez ce message que si necessaire,
pensez a l'environnement.

 

[Bart Kastermans]

Hallo pyPeople,

I wrote a little snippet of code that takes a list representing some
'digits', and according to a list of symbols, increments the digits through
the symbol list.

so for example,

digits=["a","a","a"]
symbols=["a","b","c"]

increment(digits,symbols) repeatedly would return digits as

aab
aac
aba
abb
abc
aca

etc..

Heres the code

def increment(digits,symbols):
        overflow=True
        digitpos=-1
        while overflow and -digitpos<=len(digits):
                digitsymbolindex=symbols.index(digits[digitpos])
                if digitsymbolindex==len(symbols)-1:
                        overflow=True
                        digits[digitpos]=symbols[0]
                        digitpos=digitpos-1
                else:
                        digits[digitpos]=symbols[digitsymbolindex+1]
                        overflow=False
        return digits

Now, this works. All good. It's nice and simple.  I'm just wondering how
anyone else might approach it?

I (not an expert at all) have only minor comments and one question:
comments:
why keep setting overflow to True, if you do not touch it will not
change.
digitpos -= 1 is easier to read in my mind
question:
Why first extract the indices and then compare (in your if statement),
and
why do you not just compare the symbols?

Best,
Bart