getElementsByTagName + getAttribute("class")??

hutch · Oct 20, 2005

Hi,

I'm making use of this VERY useful function for a so called 'standards
compliant' replacement for target="_blank":

function externalLinks() {
if (!document.getElementsByTagName) return;
var anchors = document.getElementsByTagName("a");
for (var i=0; i<anchors.length; i++) {
var anchor = anchors;
if (anchor.getAttribute("href") && anchor.getAttribute("rel") ==
"extlink") anchor.target = "_blank";
}
} window.onload = externalLinks;

and using it with:

<a href="mylink" rel="extlink" class="extlink">link text</a>

What I'd really like to do is make it even better and do away with the
'rel', and have it that each anchor with the "extlink" class applied to
it gets processed by the function.

I have tried replacing the relevant code with this line:

if (anchor.getAttribute("href") && anchor.getAttribute("class") ==
"extlink") anchor.target = "_blank";

cut i get 'null' as the response [i alert
'anchor.getAttribute("class")']
So any ideas why this doesnt work?

Eventually I'd like to have it that all I need to do is apply the
'extlink' class to a link, and it'll be styled as I want it AND open in
a new window.

Any pointers appreciated,
Ben

Michael Winter · Oct 20, 2005

I'm making use of this VERY useful function for a so called 'standards
compliant' replacement for target="_blank":

[code adding target attribute through script]

If you add a target attribute via a script to a document with a Strict
DTD, the resulting document tree is just as invalid as it would be if
the target attribute was present in the markup. Either use a
Transitional DTD, where the target attribute is defined, or use a Strict
DTD and ignore the error.

[snip]

if (anchor.getAttribute("href") && anchor.getAttribute("class") ==
"extlink") anchor.target = "_blank";

cut i get 'null' as the response [i alert
'anchor.getAttribute("class")']

With IE, I assume?

IE's implementation of the *Attribute methods is broken. In this
instance, it expects 'className' not 'class'.

Don't use the *Attribute methods; use the property shortcuts, like
anchor.className, instead.

[snip]

Mike

Gomolyako Eduard · Oct 20, 2005

See to Microsoft CSS Behaviors.

You can define external link in the following way:
HTML:
<head>
<style type="text/css">
a.extLink {
/*Some css properties here*/
behavior: url(extlink.htc);
}
</style>
</head>
<body>
<a href="somesite.com" class="extLink">Open somesite.com in new
window</a>
</body>

extlink.htc file:
<public:component>
<public:attach event="oncontentready" onevent="init()" />

<script language="javascript">

function init()
{
if (element && element.tagName && element.tagName.toLowerCase() ==
"a")
element.target = "_blank";
}

</script>
</public:component>

Best, Ed.

(e-mail address removed) Ð¿Ð¸ÑÐ°Ð»(Ð°):

Hutch · Oct 26, 2005

IE's implementation of the *Attribute methods is broken. In this

instance, it expects 'className' not 'class'.

Thanks, thats sorted it.

Ben

Final chapter of "Learn PHP, MySQL and JavaScript"	3	Jun 4, 2024
Only one table shows up with the information	2	Mar 29, 2023
Can someone tell me if this a real tracker? Or is it one designed to show you a different message at certain times, ie. acting like one?	0	Jan 10, 2021
Search Results with Pagination	0	Oct 25, 2024
Align separate li to right	2	Jun 19, 2024
getElementsByTagName help please	5	Mar 18, 2011
JQuery add shadow error	4	Sep 1, 2023
how do I make this case-insensitive	4	Apr 23, 2006

getElementsByTagName + getAttribute("class")??

hutch

Michael Winter

Gomolyako Eduard

Hutch

Ask a Question

Similar Threads

Members online

Forum statistics

Latest Threads