help if else

[Tonyrrr Tonyroor]

if ((( chaine[i+14] == "twincards>false</twincards")||(chaine[i+14]
== "twincards>true</twincards"))|| ( chaine[ i+14]== "twincards
xsi:nil="1"/"))


???

: syntax error, expecting end-of-file


????

 

[Jano Svitok]

if ((( chaine[i+14] == "twincards>false</twincards")||(chaine[i+14]
== "twincards>true</twincards"))|| ( chaine[ i+14]== "twincards

- xsi:nil="1"/"))
+ xsi:nil=\"1\"/"))

you have to escape quotes with \

 

[Ben Bleything]

if ((( chaine[i+14] == "twincards>false</twincards")||(chaine[i+14]
== "twincards>true</twincards"))|| ( chaine[ i+14]== "twincards
xsi:nil="1"/"))

You're closing one too many sets of parents after the "true"
conditional. Also, in the third conditional, you need to either escape
the inner quotes or use single quotes:

"twincards xsi:nil=\"1\"/"
'twincards xsi:nil="1"/'

You might want to rewrite it for better legibility, too. A suggestion:

test = chaine[ i + 14 ]
if test == 'twincards>false</twincards' or
test == 'twincards>true</twincards' or
test == 'twincards xsi:nil="1"/'

# do whatever
end

Ben

 

[Bertram Scharpf]

Hi,

Am Freitag, 27. Jul 2007, 00:21:31 +0900 schrieb Ben Bleything:

if ((( chaine[i+14] == "twincards>false</twincards")||(chaine[i+14]
== "twincards>true</twincards"))|| ( chaine[ i+14]== "twincards
xsi:nil="1"/"))

You're closing one too many sets of parents after the "true"
conditional.

You might want to rewrite it for better legibility, too. A suggestion:

test = chaine[ i + 14 ]
if test == 'twincards>false</twincards' or
test == 'twincards>true</twincards' or
test == 'twincards xsi:nil="1"/'

It's not only legibility, it's enough to calculate c[i+14]
once as the result is every time the same.

Another suggestion:

case chaine[ i+14]
when %r{twincards>(true|false)</twincards},
%q{twincards xsi:nil="1"/} then
...
end

Bertram

 

[Ben Bleything]

It's not only legibility, it's enough to calculate c[i+14]
once as the result is every time the same.

Right! I forgot to mention that

Another suggestion:

case chaine[ i+14]
when %r{twincards>(true|false)</twincards},
%q{twincards xsi:nil="1"/} then
...
end

My gut tells me this might be slower, but probably not enough to matter.
And I always forget about %q, that's really the best way to quote
something that has quotes inside it.

Ben