help

[Robert Smith]

I've written this small program to extract names from a list. It does what
it it supposed to do, but then crashes (segmentation fault) at the very end.
Can anyone tell me why?

#include <stdio.h>
#include <stdlib.h>

int main() {
char *test = "file1.jpg\nfile2.jpg\nfile3.jpg\nfilex.tga\n";
char *p = test;
char temp[13];
int i = 0; // index
memset(temp,0,13);
while (p) {
while (*p != '\n') {
temp = *p++;
i++;
}
puts(temp);
i=0;
p++; // bump over newline
}
}

 

[Ico]

I've written this small program to extract names from a list. It does what
it it supposed to do, but then crashes (segmentation fault) at the very end.
Can anyone tell me why?

#include <stdio.h>
#include <stdlib.h>

You forgot to include string.h here, you need it for the memset()

int main() {
char *test = "file1.jpg\nfile2.jpg\nfile3.jpg\nfilex.tga\n";
char *p = test;
char temp[13];
int i = 0; // index
memset(temp,0,13);
while (p) {

You probably mean 'while (*p)' here. This fixes your crash.

while (*p != '\n') {
temp = *p++;
i++;
}
puts(temp);
i=0;
p++; // bump over newline
}

When typing 'int main()', you promised you would return an integer here.

 

[Robert Smith]

I've written this small program to extract names from a list. It does what
it it supposed to do, but then crashes (segmentation fault) at the very end.
Can anyone tell me why?

#include <stdio.h>
#include <stdlib.h>

You forgot to include string.h here, you need it for the memset()

int main() {
char *test = "file1.jpg\nfile2.jpg\nfile3.jpg\nfilex.tga\n";
char *p = test;
char temp[13];
int i = 0; // index
memset(temp,0,13);
while (p) {

You probably mean 'while (*p)' here. This fixes your crash.

while (*p != '\n') {
temp = *p++;
i++;
}
puts(temp);
i=0;
p++; // bump over newline
}

When typing 'int main()', you promised you would return an integer here.

}

Thanks. That solved my problem.

Just also wondering, if you declare char *x = "some string";, will it
append a \0 at the end?

 

[Vladimir S. Oka]

I've written this small program to extract names from a list. It does what
it it supposed to do, but then crashes (segmentation fault) at the very end.
Can anyone tell me why?

#include <stdio.h>
#include <stdlib.h>

You forgot to include string.h here, you need it for the memset()

int main() {
char *test = "file1.jpg\nfile2.jpg\nfile3.jpg\nfilex.tga\n";
char *p = test;
char temp[13];
int i = 0; // index
memset(temp,0,13);
while (p) {

You probably mean 'while (*p)' here. This fixes your crash.

while (*p != '\n') {
temp = *p++;
i++;
}
puts(temp);
i=0;
p++; // bump over newline
}

When typing 'int main()', you promised you would return an integer here.

}

Thanks. That solved my problem.

Just also wondering, if you declare char *x = "some string";, will it
append a \0 at the end?

Yes, it will. Do note, however, that `x` is assigned a pointer to a
string literal "some string" which is not modifiable, and not reachable
in any other way. I.e., you can't do things like `x[0] = 'c'`, and
assigning a different pointer to `x` without saving the previous value
will make "some string" instance unraechable. See also <c-faq.com>, it
has good discussion on this (certainly better than what I just knocked
up).

 

[Herbert Rosenau]

I've written this small program to extract names from a list. It does what
it it supposed to do, but then crashes (segmentation fault) at the very end.
Can anyone tell me why?

#include <stdio.h>
#include <stdlib.h>

int main() {
char *test = "file1.jpg\nfile2.jpg\nfile3.jpg\nfilex.tga\n";
char *p = test;
char temp[13];
int i = 0; // index
memset(temp,0,13);
while (p) {

Why does you test the pointer insted the char the pointer points to?

while (*p != '\n') {
temp = *p++;
i++;
}
puts(temp);
i=0;
p++; // bump over newline
}
}

--
Tschau/Bye
Herbert

Visit http://www.ecomstation.de the home of german eComStation
eComStation 1.2 Deutsch ist da!