how to refactor these code?

[Zhenning Guan]

def ss(s = 'hello', yeah = nil)
if yeah
puts "something"
else
puts "other thing"
end

#code continue ....
end

I have this method, use it like that:

ss('hi', yeah = true)
ss('hello')
ss('****', yeah = true)
ss('hello',yeah = true)

very ugly.. sometimes I just need to passed yeah = true, but I have to
added 'hello' first.

what should I do?

 

[burke]

A little more context would be helpful, but you could do something
like:

def ss(options={})
s = options.deletes) || "hello"
yeah = options.deleteyeah)

puts (yeah ? "something" : "other thing")

#code continue ....
end

sshello => 'hi', :yeah => true)
ssyeah => false)

and so on.

Burke Libbey

 

[Robert Klemme]

def ss(s =3D 'hello', yeah =3D nil)
=A0if yeah
=A0 =A0puts "something"
=A0else
=A0 =A0puts "other thing"
=A0end

=A0#code continue ....
end

What do you need argument "s" for?

I have this method, use it like that:

ss('hi', yeah =3D true)
ss('hello')
ss('****', yeah =3D true)
ss('hello',yeah =3D true)

very ugly.. sometimes I just need to passed yeah =3D true, but I have to
added 'hello' first.

what should I do?

Define two methods. At least from the interface this is cleaner.
Generally flags that control method behavior are considered bad
practice because they tend to make the implementation of a method more
complex and tie things together that might really be independent (just
consider what happens if you inherit a class and want to change only
one of the two variants).

Note, you can still share an internal implementation under the hood e.g.

def ss1
ss_impl "something"
end

def ss2
ss_impl "other thing"
end

private
def ss_impl(x)
...
end

But your example is really a bit short to come up with a definitive
answer how to improve this.

Kind regards

robert

--=20
remember.guy do |as, often| as.you_can - without end
http://blog.rubybestpractices.com/