iterating over array of variables - can't change them?

A

AJS

title="Title"
subtitle="Subtitle"
body="Body"
[title,subtitle,body].each {|item| item.downcase!}

This successfully sets the original variables to "title", "subtitle",
"body"

BUT

[title,subtitle,body].each {|item| item=""}

has no effect.

Why doesn't this work? How can I make it work?

thanks
 
D

Drew Olson

AJS said:
title="Title"
subtitle="Subtitle"
body="Body"
[title,subtitle,body].each {|item| item.downcase!}

You're looking for map, which performs the action on each element and
creates a new array with the results:

[title,subtitle,body].map{|item| item.downcase}
 
S

Stefano Crocco

Alle venerd=EC 4 gennaio 2008, AJS ha scritto:
title=3D"Title"
subtitle=3D"Subtitle"
body=3D"Body"
[title,subtitle,body].each {|item| item.downcase!}

This successfully sets the original variables to "title", "subtitle",
"body"

BUT

[title,subtitle,body].each {|item| item=3D""}

has no effect.

Why doesn't this work? How can I make it work?

thanks

The block variable (item) is set by ruby to "point to" each object of the=20
array in turn. String#downcase! is a destructive method: it changes its=20
receiver, so the elements of the original array get changed. On the other=20
hand, when you do item =3D "", you're telling the variable itewm to "point =
to"=20
another object, a new (empty) string. This doesn't modify the original arra=
y=20
at all.

If you want to change the contents of the original array, your should use=20
Array#map!:

[title,subtitle,body].map! {|item| ""}

Array#map! replaces each element of the array with the return value of the=
=20
block.

I hope this helps

Stefano
 
R

Robert Klemme

title="Title"
subtitle="Subtitle"
body="Body"
[title,subtitle,body].each {|item| item.downcase!}

This successfully sets the original variables to "title", "subtitle",
"body"

BUT

[title,subtitle,body].each {|item| item=""}

has no effect.

Why doesn't this work? How can I make it work?

It does not work because you assign to "item" which is a local variable
in the block. And since you do not change string objects in the Array
you do not see any change. In your case you should change the original
object, e.g.

[title,subtitle,body].each {|item| item.replace ""}
[title,subtitle,body].each {|item| item.sub! /.*/, ""}

More generally you can also change the array via assignment by doing

an_array.map! { "" }

But this again won't change the objects referenced by "title" etc.

HTH

robert
 
S

Sebastian Hungerecker

AJS said:
title="Title"
subtitle="Subtitle"
body="Body"
[title,subtitle,body].each {|item| item.downcase!}

This successfully sets the original variables to "title", "subtitle",
"body"

No, it doesn't. It changes the strings, it doesn't do anything to the
variables. The variables still point to the same object as before, it's
just the objects that are different now.

[title,subtitle,body].each {|item| item=""}

has no effect.

Why doesn't this work? How can I make it work?

It works just fine. It just doesn't do what you want it to. Here's what it
does:
It takes each of the elements in the array and then yields it. The code in the
block will then run with item pointing to the element. After the assignment
(item="") item will point to an empty string. This has no effect whatsoever
on the variables title, subtitle and body.
What you want is map instead of each (which gives you a new array containing
the results of yielding each item) or String#replace instead of reassignment
(which would change the object instead of the variable).


HTH,
Sebastian
 
K

Ken Bloom

title="Title"
subtitle="Subtitle"
body="Body"
[title,subtitle,body].each {|item| item.downcase!}

This successfully sets the original variables to "title", "subtitle",
"body"

BUT

[title,subtitle,body].each {|item| item=""}

has no effect.

Why doesn't this work? How can I make it work?

thanks

Refer to the variables as strings and use eval.

["title","subtitle","body"].each {|item| eval "#{item}=''"}

--Ken
 
R

Robert Klemme

title="Title"
subtitle="Subtitle"
body="Body"
[title,subtitle,body].each {|item| item.downcase!}

This successfully sets the original variables to "title", "subtitle",
"body"

BUT

[title,subtitle,body].each {|item| item=""}

has no effect.

Why doesn't this work? How can I make it work?

thanks

Refer to the variables as strings and use eval.

["title","subtitle","body"].each {|item| eval "#{item}=''"}

I believe this is rather inefficient (aka slow) and more importantly
will not run under all circumstances ($SAFE). Plus, it's not needed. :)

Kind regards

robert
 
K

Ken Bloom

title="Title"
subtitle="Subtitle"
body="Body"
[title,subtitle,body].each {|item| item.downcase!}

This successfully sets the original variables to "title", "subtitle",
"body"

BUT

[title,subtitle,body].each {|item| item=""}

has no effect.

Why doesn't this work? How can I make it work?

thanks

Refer to the variables as strings and use eval.

["title","subtitle","body"].each {|item| eval "#{item}=''"}

I believe this is rather inefficient (aka slow) and more importantly
will not run under all circumstances ($SAFE). Plus, it's not needed.
:)

Whether or not it's needed depends entirely on how much he's condensed
the example to post it here. If he were interested in changing the class
of object, this is the only technique that would update the variables
automatically.

(So I'm doing more than the minimum needed to make the test case work, so
I'm not a real extreme programmer.)

--Ken
 

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments. After that, you can post your question and our members will help you out.

Ask a Question

Members online

Forum statistics

Threads
474,275
Messages
2,571,375
Members
48,067
Latest member
MackenzieP

Latest Threads

Top