Redefining initialize while staying -w clean

[Daniel Berger]

Hi all,

Is it possible to redefine initialize and stay -w clean? In win32-file-
stat, I've redefined initialize to suit my needs for MS Windows.

If I do "undef_methodinitialize)" and run with -w, I'll get:

"warning: undefining `initialize' may cause serious problem".

However, if don't do that, I get "warning: method redefined;
discarding old initialize".

Help! I'm trapped!

Thanks,

Dan

 

[James Edward Gray II]

If I do "undef_methodinitialize)" and run with -w, I'll get:

"warning: undefining `initialize' may cause serious problem".

Does this work?

remove_methodinitialize) if method_defined? :initialize

James Edward Gray II

 

[Andrew Johnson]

Hi all,

Is it possible to redefine initialize and stay -w clean? In win32-file-
stat, I've redefined initialize to suit my needs for MS Windows.

If I do "undef_methodinitialize)" and run with -w, I'll get:

"warning: undefining `initialize' may cause serious problem".

However, if don't do that, I get "warning: method redefined;
discarding old initialize".

Try aliasing the method before redefining it:

alias ld_init :initialize
def initialize() end

regards,
andrew

 

[Daniel Berger]

Does this work?

remove_methodinitialize) if method_defined? :initialize

Unfortunately, using remove_method just issues a different message:
"warning: removing `initialize' may cause serious problem"

Regards,

Dan

 

[Daniel Berger]

Try aliasing the method before redefining it:

alias ld_init :initialize
def initialize() end

That doesn't appear to work. Do you have a code snippet where it does
work? Perhaps I've missed something.

Thanks,

Dan

 

[James Edward Gray II]

That doesn't appear to work. Do you have a code snippet where it does
work? Perhaps I've missed something.

Remove the colons or swap alias with alias_method and add a comma.

James Edward Gray II

 

[Andrew Johnson]

That doesn't appear to work. Do you have a code snippet where it does
work? Perhaps I've missed something.

Perhaps I've misunderstood your case -- the following runs -w clean on
Ruby 1.8.6

$ cat init.rb

class String
alias ld_init :initialize
def initialize() end
end

$ ruby -w init.rb
$

andrew

 

[Daniel Berger]

Perhaps I've misunderstood your case -- the following runs -w clean on
Ruby 1.8.6

$ cat init.rb

class String
alias ld_init :initialize
def initialize() end
end

Oh, I see. I had to remove the undef_methodinitialize) call with
this approach. Alright, this feels a bit clunky, but it will do the
job. The only thing I'm going to change is to making old_init
private.

Many thanks,

Dan

 

[James Edward Gray II]

Oh, I see. I had to remove the undef_methodinitialize) call with
this approach. Alright, this feels a bit clunky, but it will do the
job. The only thing I'm going to change is to making old_init
private.

Can't you safely remove it once it has been renamed?

James Edward Gray II

 

[Daniel Berger]

Can't you safely remove it once it has been renamed?

Looks that way. This ran -w clean for me:

class String
alias old_init initialize
def initialize
puts "hello"
end
remove_methodold_init)
end

Regards,

Dan

 

[Daniel Berger]

Looks that way. This ran -w clean for me:

class String
alias old_init initialize
def initialize
puts "hello"
end
remove_methodold_init)
end

Quick followup. For singleton methods you MUST use the "class << self"
style for both the alias and the definition to avoid warnings:

# This is -w clean
class File
class << self
alias :basename_orig :basename
def basename
puts "hello"
end
remove_methodbasename_orig)
end
end

# This is not
class File
class << self
alias :basename_orig :basename
end

def self.basename
puts "hello"
end

class << self
remove_methodbasename_orig)
end
end

Regards,

Dan