Shrikage: regexp rookie

[Don Stefani]

Hello,
I'm cleaning up this data string before it's written to a flat file.
I'd like to know if/how I can shorten this regexp, so it's sexier. ;-)
Chick's dig sexy code!

Original line:
Color: R14/88H Golden Wheat<br>Size: Average<br>

My regexp:
$ary2[2] =~ s/(Color:|Size//g;
$ary2[2] =~ s/(\<br\>)/,/g;
$ary2[2] =~ s/(^\s+)//;

Thanks,

Don

 

[Gunnar Hjalmarsson]

I'd like to know if/how I can shorten this regexp, so it's sexier.
;-) Chick's dig sexy code!

Original line:
Color: R14/88H Golden Wheat<br>Size: Average<br>

My regexp:
$ary2[2] =~ s/(Color:|Size//g;
$ary2[2] =~ s/(\<br\>)/,/g;
$ary2[2] =~ s/(^\s+)//;

Not sure about your definition of 'sexy', but...

$ary2[2] = "$1,$2" if $ary2[2] =~ /:\s+(.+?)<.+?:\s+([^<]+)/;

 

[Uri Guttman]

I'd like to know if/how I can shorten this regexp, so it's sexier.
;-) Chick's dig sexy code!
Original line:
Color: R14/88H Golden Wheat<br>Size: Average<br>
My regexp:
$ary2[2] =~ s/(Color:|Size//g;
$ary2[2] =~ s/(\<br\>)/,/g;

$ary2[2] =~ s/(^\s+)//;

that doesn't need the () as you don't grab or group anything.

Not sure about your definition of 'sexy', but...

$ary2[2] = "$1,$2" if $ary2[2] =~ /:\s+(.+?)<.+?:\s+([^<]+)/;

blech!!

<all untested>

why not just use s///?

$ary2[2] =~ s/:\s+(.+?)<.+?:\s+([^<]+)/$1,$2/ ;

and that can be cleaned up too:

$ary2[2] =~ s/:\s+(.+?)<.+?:\s+(.+?)</$1,$2/ ;

now remove the regex redundancy:

$ary2[2] = join( ',', $ary2[2] =~ /:\s+(.+?)</g ) ;

and then remove the var redundancy:

$_ = join( ',', /:\s+(.+?)</g ) for $ary2[2] ;

bug alert: gunnar's and my code didn't replace the last <br> with , but
that is easily corrected.

now, that will get you the girl!

uri

 

[Don Stefani]

$_ = join( ',', /:\s+(.+?)</g ) for $ary2[2] ;

Thank you.

Don

 

[Michele Dondi]

I'd like to know if/how I can shorten this regexp, so it's sexier. ;-) [snip]
My regexp:
$ary2[2] =~ s/(Color:|Size//g;
$ary2[2] =~ s/(\<br\>)/,/g;
$ary2[2] =~ s/(^\s+)//;

Others have suggested some WTDI in one regex. To me it is sexier if it
is more simple and I find it easier to understand and possibly
maintain if three regex are used as you did. Only, do yourself a favor
and do not use three =~; take an advantage of foreach aliasing
instead: it is even in the faq IIRC! Try this (untested),

s/(?:Color|Size)://g, s/<br>/,/g, s/^\s*// for $ary2[2];


HTH,
Michele