So Simple but doesn't work

[jimandy]

This is driving me crazy. Seems like it should alert with the innerHTML from each <p> element, but it doesn't.

<script>
    function doit() {
    items=document.getElementsByTagName("p");
        for(var i=0; i<items.length; i++);
        {
        alert(items[i].innerHTML);
        }//end for loop     
    }//end foo

</script>

<p>abc</p>
<p>xyz</p>
<button onclick="doit()"> CLICK </button>

 

[VBService]

Removed semicolon after the for loop declaration. Without the semicolon, the block of code within {} will be executed for each element.

for (var i=0; i<items.length; i++);

<script>
  function doit() {
    items = document.getElementsByTagName("p");
    for (var i=0; i<items.length; i++) {
      alert(items[i].innerHTML);
    } //end for loop  
  } //end foo
</script>

<p>abc</p>
<p>xyz</p>
<button onclick="doit()"> CLICK </button>

BTW,

<script>
  function doit() {
    const items = document.getElementsByTagName("p");
    for (const item of items) {
      alert(item.textContent);
    }  
  }
</script>

<p>abc</p>
<p>xyz</p>
<button onclick="doit()"> CLICK </button>

<script>
  function doit() {
    const items = document.querySelectorAll('p');
    for (const item of items) {
      if (item.innerText === item.innerHTML)
        alert(item.textContent); //This element contains only text
      else
        alert(item.textContent + '\n' + item.innerHTML); // This element contains tags and text
    }   
  }
</script>

<p>abc</p>
<p>xyz<span>abc</span></p>
<p><b>abc</b>def</p>
<p>xyzXYZ</p>
<button onclick="doit()">CLICK</button>

 

[jimandy]

Removed semicolon after the for loop declaration. Without the semicolon, the block of code within {} will be executed for each element.

for (var i=0; i<items.length; i++);

<script>
  function doit() {
    items = document.getElementsByTagName("p");
    for (var i=0; i<items.length; i++) {
      alert(items[i].innerHTML);
    } //end for loop 
  } //end foo
</script>

<p>abc</p>
<p>xyz</p>
<button onclick="doit()"> CLICK </button>

BTW,

<script>
  function doit() {
    const items = document.getElementsByTagName("p");
    for (const item of items) {
      alert(item.textContent);
    } 
  }
</script>

<p>abc</p>
<p>xyz</p>
<button onclick="doit()"> CLICK </button>

<script>
  function doit() {
    const items = document.querySelectorAll('p');
    for (const item of items) {
      if (item.innerText === item.innerHTML)
        alert(item.textContent); //This element contains only text
      else
        alert(item.textContent + '\n' + item.innerHTML); // This element contains tags and text
    }  
  }
</script>

<p>abc</p>
<p>xyz<span>abc</span></p>
<p><b>abc</b>def</p>
<p>xyzXYZ</p>
<button onclick="doit()">CLICK</button>

 

[jimandy]

THANKS VB!!!