strange, non-repetitious error

[Pan Kracy]

Hello

I have that exception sometimes: "can't convert false into Integer"
This error is non-repetitious.
This exception occur once in a while when I run progam on the same data.

sample code:

for z in 1..lines.length
line = lines[z-1] # this is the line where error occur
end

Is it a ruby implementation problem?

Greetings

 

[Robert Klemme]

Hello

I have that exception sometimes: "can't convert false into Integer"
This error is non-repetitious.
This exception occur once in a while when I run progam on the same data.

sample code:

for z in 1..lines.length
line = lines[z-1] # this is the line where error occur
end

Is it a ruby implementation problem?

Most likely not. We can't say without seeing more code. What type of
object is "lines"?

Why don't you just do

lines.each do |line|
end

?

Kind regards

robert

 

[Pan Kracy]

I don't use "lines.each do |line|" because I need number of line.

This is the code:

File.open(procsw[j-1],'r+') do |file|
lines = file.readlines
for z in 1..lines.length
line = lines[z-1] #can't convert false into integer
if(line!=nil and line!="") then
line.downcase.gsub("external name") do
if(line.index(/'.*'/)!=nil) then
line.gsub(/'.*'/) {|match|
k = match.rindex("/")
line = "'" + bladePath + match.slice(k..match.length)
+ "\n"
}
else
lines[z].gsub(/'.*'/) {|match|
k = match.rindex("/")
lines[z] = "'" + bladePath +
match.slice(k..match.length) + "\n"
}
end
end
end
end
file.pos = 0
file.print lines
file.truncate(file.pos)
file.close
end

 

[Stefano Crocco]

I don't use "lines.each do |line|" because I need number of line.

Do you know about Array#each_index and Array#each_with_index?:

['a', 'b', 'c'].each_index{|i| puts i}

Output:
0
1
2

['a', 'b', 'c'].each_with_index{|obj, i| puts "i: #{i}, obj: #{obj}"}

Output:
i: 0, obj: a
i: 1, obj: b
i: 2, obj: c

Stefano

 

[Rick DeNatale]

I don't use "lines.each do |line|" because I need number of line.

lines.each_with_index do | line, z|
...

 

[Pan Kracy]

I will try with
lines.each_with_index do | line, z|

Thank you all for replies.
Greetings

 

[Robert Klemme]

I will try with

lines.each_with_index do | line, z|

You should change a lot more. For example, you have nested
invocations of gsub on the same line (albeit sometimes with a
#downcase so it's probably not the same instance).

You also do not need the "file.close" because your block ensures the
file will be closed properly.

Also, I do not see how z can ever be a non Fixnum in your code. Are
you sure this is the code that produces the error? Do you happen to
have multiple threads all of them using a z which is defined outside
the code you show?

In your case I'd rather use #map instead of normal iteration since you
seem to be replacing line contents with something else.

Or wait, there seems to be a off by one error lurking: you use
1..lines.length for iteration, read lines[z-1] but later lines[z].
lines[z] does not exist for z==lines.length. You either need to
change logic or use the three dots range for iteration.

Kind regards

robert

 

[Jano Svitok]

2008/4/7, Pan Kracy <[email protected]>:
You should change a lot more. For example, you have nested

...

I agree with Robert. Maybe if you describe what you are trying to
achieve, somebody would help with a cleaner solution.

J.