Unexpected 1 in Error File From DBI->connect

[Bob Smith]

Using perl 5.8.7 and DBI 1.53 on a Linux system, the following
function outputs a spurious "1" to the web server's error file on the
DBI->connect line:

sub DBConnect
{
my ($DataBase) = @_;

my $DSN_SFS = "DBI:mysql:$DataBase"; # Data Source Name
my $DSN_USER = "root"; # ... (user name)
my $DSN_PWD = "secret"; # ... (password)

my %attr = (PrintError => 0, ## Don't report errors via warn ()
RaiseError => 0 ## Don't report errors via die ()
);
$dbh = DBI->connect ($DSN_SFS, $DSN_USER, $DSN_PWD, \%attr) or die
print "Can't open database <$DSN_SFS>"
. "<br />$DBI::errstr";
return $dbh;
}

Otherwise, the function works just fine. Any ideas on what could be
triggering the spurious output?

 

[Paul Lalli]

Using perl 5.8.7 and DBI 1.53 on a Linux system, the following
function outputs a spurious "1" to the web server's error file
on the DBI->connect line:

sub DBConnect
{
my ($DataBase) = @_;
my $DSN_SFS = "DBI:mysql:$DataBase"; # Data Source Name
my $DSN_USER = "root"; # ... (user name)
my $DSN_PWD = "secret"; # ... (password)

my %attr = (PrintError => 0, ## Don't report errors via warn ()
RaiseError => 0 ## Don't report errors via die ()
);
$dbh = DBI->connect ($DSN_SFS, $DSN_USER, $DSN_PWD, \%attr) or die
print "Can't open database &lt;$DSN_SFS&gt;"
. "<br />$DBI::errstr";
return $dbh;

}

Otherwise, the function works just fine. Any ideas on what
could be triggering the spurious output?

die() takes a string to print to STDERR and exits the program.
print() takes a string to print to STDOUT and returns 1 if successful.

die(print("whatever"));
will therefore print "whatever" to STDOUT, and return 1 to die().
die() will then print 1 to STDERR and exit the program.

Change die(print("whatever")) to die("whatever");

Paul Lalli

 

[Bob Smith]

die() takes a string to print to STDERR and exits the program.
print() takes a string to print to STDOUT and returns 1 if successful.

die(print("whatever"));
will therefore print "whatever" to STDOUT, and return 1 to die().
die() will then print 1 to STDERR and exit the program.

Change die(print("whatever")) to die("whatever");

Excellent explanation! Many thanks!