verbose sort

[bob smith]

I have some code that sorts a list like so:

Vector<String> my_list = new Vector<String>();


Comparator<String> c = new Comparator<String>() {
@Override
public int compare(String object1, String object2) {
if (object1 == null)
return -1;
if (object2 == null)
return 1;
object1 = object1.toLowerCase();
object2 = object2.toLowerCase();
return object1.compareTo(object2);
};
};

Collections.sort(my_list, c);


This seems like a lot of code for such a common operation. Is there a more succinct way of doing this?

 

[Eric Sosman]

I have some code that sorts a list like so:

Vector<String> my_list = new Vector<String>();


Comparator<String> c = new Comparator<String>() {
@Override
public int compare(String object1, String object2) {
if (object1 == null)
return -1;
if (object2 == null)
return 1;
object1 = object1.toLowerCase();
object2 = object2.toLowerCase();
return object1.compareTo(object2);
};
};

Collections.sort(my_list, c);


This seems like a lot of code for such a common operation. Is there a more succinct way of doing this?

Consider using compareToIgnoreCase(). Also, think about what
happens when two null's are compared: You should return zero rather
than declaring one of them "less than" the other, because otherwise
your comparator is inconsistent (you can have A<B, B<C, but C<A).

public int compare(String s1, String s2) {
if (s1 == null)
return s2 == null ? 0 : -1;
return s2 == null ? +1 : s1.compareToIgnoreCase(s2);
}

 

[markspace]

I have some code that sorts a list like so:

Vector<String> my_list = new Vector<String>();


Comparator<String> c = new Comparator<String>() {
@Override
public int compare(String object1, String object2) {
if (object1 == null)
return -1;
if (object2 == null)
return 1;
object1 = object1.toLowerCase();
object2 = object2.toLowerCase();
return object1.compareTo(object2);
};
};

Collections.sort(my_list, c);


This seems like a lot of code for such a common operation.
Is there a more succinct way of doing this?

Collections.sort( my_list, String.CASE_INSENSITIVE_ORDER );

 

[Eric Sosman]

Collections.sort( my_list, String.CASE_INSENSITIVE_ORDER );

Throws NullPointerException if the list has any nulls.

 

[markspace]

Throws NullPointerException if the list has any nulls.

That's unfortunate. I thought there were more "pre-made" Comparators,
but couldn't find any. That too bad too, some wrappers would handle a
large number of situations, including null checks.

I really thought there were more Comparators in the API, I might just be
missing them.

 

[Daniel Pitts]

That's unfortunate. I thought there were more "pre-made" Comparators,
but couldn't find any. That too bad too, some wrappers would handle a
large number of situations, including null checks.

I really thought there were more Comparators in the API, I might just be
missing them.

I believe Apache Commons has a bunch of useful generic Comparator
implementations.

 

[Lew]

I have some code that sorts a list like so:

Vector<String> my_list = new Vector<String>();

Comparator<String> c = new Comparator<String>() {
@Override
public int compare(String object1, String object2) {
if (object1 == null)
return -1;

if (object2 == null)
return 1;

object1 = object1.toLowerCase();
object2 = object2.toLowerCase();

return object1.compareTo(object2);
};
};

Collections.sort(my_list, c);

This seems like a lot of code for such a common operation. Is there a more succinct way of doing this?

Others have shown ways to shorten this, but I'm curious.

"Seems" - such a duck-and-cover word. You made an assessment.
Based on what criteria?

What is "a lot"?

You could write a cover method.

Apache Commons might have a utility class for that.

 

[bob smith]

Collections.sort( my_list, String.CASE_INSENSITIVE_ORDER );

Very nice, thanks.

 

[Roedy Green]

This seems like a lot of code for such a common operation. Is there a more succinct way of doing this?

see http://mindprod.com/applet/comparatorcutter.html
--
Roedy Green Canadian Mind Products
http://mindprod.com
The greatest shortcoming of the human race is our inability to understand the exponential function.
~ Dr. Albert A. Bartlett (born: 1923-03-21 age: 89)