Byte array

[Mike Schilling]

Next problem I've got is that I get the message: "code too large"
when I try to compile. Have I got to break up the byte array(s) and
put them in separate constants classes?

The "too large" probably refers to your method. Break up the
intiialization into multiple methods, and write a master method that
calls all of them.

 

[markspace]

Next problem I've got is that I get the message: "code too large" when I
try to compile. Have I got to break up the byte array(s) and put them in
separate constants classes?

So, copying and pasting a 20k byte buffer turned out to be a bad idea,
just like everyone said? Imagine that.

Read the file as input, make the byte buffer from that. I think you're
done with the god-awful kludges.

 

[Joshua Cranmer]

Next problem I've got is that I get the message: "code too large" when I
try to compile. Have I got to break up the byte array(s) and put them in
separate constants classes?

A method is limited to 65,536 method length. The brunt of the array
would be a dup, [iconst_n | bipush | sipush | ldc], bipush, bastore. If
it's a class field, that would also include an sipush, anewarray,
aload_0, setfield, and a return: for a total of 10 bytes meta.

You have 6 5-byte pushes, 122 6-byte pushes, and the rest (until 32768)
7-byte, assuming that you don't have numbers below 6. Doing the math,
that gets you a total of 9,380 elements before you exceed method length.

 

[Dirk Bruere at NeoPax]

So, copying and pasting a 20k byte buffer turned out to be a bad idea,
just like everyone said? Imagine that.

Read the file as input, make the byte buffer from that. I think you're
done with the god-awful kludges.

Yes, and "probably not"

--
Dirk

http://www.transcendence.me.uk/ - Transcendence UK
http://www.theconsensus.org/ - A UK political party
http://www.onetribe.me.uk/wordpress/?cat=5 - Our podcasts on weird stuff

 

[Daniel Pitts]

It's going to be just as hard to put them in a file and read it as hard
coding them in from the start. I'll make an int array and then convert
to bytes as I read from it.

Not so hard:
class DataClass {
private static final byte[] data;
static {
try {
ByteArrayOutputStream out = new ByteArrayOutputStream();
InputStream stream = DataClass.class.getResourceAsStream("d.data");
int read;
while ((read = stream.read()) >= 0) {
out.write(read);
}
stream.close();
data = out.toByteArray();
} catch(Exception e) {
throw new RuntimeException("Could not load data");
}
}
}

 

[Lew]

int read;
while ((read = stream.read()) >= 0) {
out.write(read);
}

Or, for better control of the scope of variable 'read':

for ( int read; (read = stream.read()) >= 0; )
{
out.write(read);
}

 

[Dirk Bruere at NeoPax]

It's going to be just as hard to put them in a file and read it as
hard coding them in from the start. I'll make an int array and then
convert to bytes as I read from it.

Not so hard:
class DataClass {
private static final byte[] data;
static {
try {
ByteArrayOutputStream out = new ByteArrayOutputStream();
InputStream stream = DataClass.class.getResourceAsStream("d.data");
int read;
while ((read = stream.read()) >= 0) {
out.write(read);
}
stream.close();
data = out.toByteArray();
} catch(Exception e) {
throw new RuntimeException("Could not load data");
}
}
}

Thanks - I'll use it to tidy up the code.
I love the way a simple question turns into a huge discussion

--
Dirk

http://www.transcendence.me.uk/ - Transcendence UK
http://www.theconsensus.org/ - A UK political party
http://www.onetribe.me.uk/wordpress/?cat=5 - Our podcasts on weird stuff