design criticism

[Nick Keighley]

*Nick Keighley:

context is everything...

but in general, being prepared to make a fool of oneself often pays
off!

Just a misunderstanding.

The code presented uses "protected:" for functions that really should be
"private:".

ah, so I read what you wrote- just ignored the context in which it
was
written.

When protected is wise to use is still something I'm getting
to grips with. My current rules of thumb: make data private, make
"interface
methods" public non-virtual functions, make over-ridable
"implementation
methods" virtual protected functions.

As with all rules of thumb they get broken (I commonly have public
virtual
functions).

Cheers, & hth.,

yes, ta

 

[mike3]

* mike3:







Yes, it's known as "God" object (or class).

Such large classes are symptomatic of lack of design.

A class that has evolved to take on more and more responsibilities.

Eww. You mean like putting the whole darned program into one
giant, bloated object?