Only one point of return

[Jerry Coffin]

* (e-mail address removed):

[ ... ]

Bad, because it uses global variables, and is unclear.

Are you really want it to do one of the things without doing both?

I think you're right that the usual intent is more like this:

bool f() {

if ( pointer1 == 0 || pointer2 == 0)
return false;

pointer1->doSomething();
pointer2->doSomething();
return true;
}

But if so, try

bool f()
{
if( pointer1 != 0 )
{
pointer1->doSomething();
if( pointer1 != 0 )

Presumably you meant pointer2 here.

{
pointer2->doSomething1();
return true;
}
}
return false;
}

Personally, I think I'd generally prefer something like this:

bool f() {
if (pointer1 != 0) {
pointer1->doSomething();
if (pointer2 != 0)
pointer2->doSomething();
}
return (pointer1 != 0) && (pointer2 != 0);
}